Skip to content

Implementation of Euclideans Algorithm in Kotlin. #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 4, 2019
Merged

Implementation of Euclideans Algorithm in Kotlin. #589

merged 5 commits into from
Feb 4, 2019

Conversation

olaven
Copy link
Contributor

@olaven olaven commented Jan 31, 2019

This is my first time contributing to this project.
Hopefully, I've done everything correctly.
Otherwise, let me know, and I will fix it as fast as possible 🚂🚋🚋

Thank you for creating such an inspiring project🌦

@june128 june128 added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Jan 31, 2019
@berquist berquist self-assigned this Feb 2, 2019
berquist
berquist requested changes Feb 2, 2019
View reviewed changes
Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Kotlin is a great language and I am glad multiple people are now writing in it here.

Because these are all functions, can you put everything into one file, and have main call both euclidMod and euclidSub?

@berquist
Copy link
Member

berquist commented Feb 2, 2019

Oh, there is one other thing I noticed that isn't something you need to change for this PR. I see that you're making the PR from the master branch of your fork. Once you start making multiple PRs for a project (not just this one, any one), or if you want to update your fork's master from the upstream master, your life will become hell. You should make a branch for your code and do the PR from there: https://github.com/algorithm-archivists/algorithm-archive/wiki/How-to-Contribute#step-32---branching

@olaven
Copy link
Contributor Author

olaven commented Feb 3, 2019

Thank you for the improvements and advice😄 I greatly appreaciate it.
I believe everything is resolved with #589. If not, let me know.

berquist
berquist requested changes Feb 3, 2019
View reviewed changes
@berquist @olaven
Update contents/euclidean_algorithm/code/kotlin/Euclidean.kt
1100581 
Co-Authored-By: olaven <olavsundfoer@gmail.com>
@berquist
Copy link
Member

berquist commented Feb 4, 2019 •
edited
Loading

Looks good, thanks again! I'm even gonna leave all the emoji in the commit log.

Edit: aw, the message isn't what I thought it was. Oh well!

@berquist berquist merged commit c53c762 into algorithm-archivists:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berquist berquist berquist approved these changes

Assignees

@berquist berquist

Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olaven @berquist @june128